Enable port number directly type in and fix http request bug#18
Closed
lawrencehj wants to merge 2 commits intoHardwareMonitor:masterfrom
Closed
Enable port number directly type in and fix http request bug#18lawrencehj wants to merge 2 commits intoHardwareMonitor:masterfrom
lawrencehj wants to merge 2 commits intoHardwareMonitor:masterfrom
Conversation
…ype in port number directly
…he sensor id with symbol like {}
sergiye
added a commit
that referenced
this pull request
Mar 30, 2026
sergiye
added a commit
that referenced
this pull request
Mar 30, 2026
Collaborator
|
thanks for finding bugs, but нour version of fixes isn't entirely correct. Simply removing the minimum in the port value isn't enough. The sensor ID needs to be escaped in the request address itself (http://127.0.0.1:8088/Sensor?action=Get&id=/nic/%257B3610E5A6-B1A2-46DE-ABCD-CA9D97BDE218%257D/throughput/7). But thanks to this, there's now error handling in the HTTP server, and the user will receive a 400 Bad Request error if the request is invalid. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for example:
http://127.0.0.1:8088/Sensor?action=Get&id=/nic/%7B3610E5A6-B1A2-46DE-ABCD-CA9D97BDE218%7D/throughput/7