Persist DM screen splitter sizes across reloads#339
Merged
Conversation
Sizes for the campaign DM screen's wide-layout splitters (left/mid/right columns and the two inner vertical splits) are now saved to localStorage on drag release and restored on reload, preserving DMs' preferred layout between sessions. Stored as percentages so they remain layout-relative across screen resolutions. Async hk-pane is overridden with a sync local registration in this view so all Splitpanes children mount synchronously, avoiding splitpanes' equalize-on-add cascade that would otherwise overwrite the saved sizes with redistributed defaults.
Lakeyzer
approved these changes
Jun 26, 2026
|
HarmlessHarm
pushed a commit
that referenced
this pull request
Jul 7, 2026
Brings in NPC groups, campaign view refactor (#341), DM screen splitter persistence (#339), Set Initiative NPC button (#344), and monster filter changes (#345), re-expressed in Vue 3 syntax where main's code still used Vue 2 patterns: - slot="x" attributes -> v-slot templates (NpcGroupManager, BasicInfo, Npcs, Entities dialogs) - $set/$delete/Vue.set/Vue.delete -> direct assignment (npcGroups and npcs store modules, hk-filter, Entities, BasicInfo) - vue-snotify -> Quasar notify utils (NpcGroupManager, Entities, Npcs) - vee-validate v3 slot props -> v4 errorMessage API (BasicInfo) - QTable :data -> :rows; () => import() -> defineAsyncComponent - process.browser -> typeof window guard in browserDetect (app failed to boot server- and client-side otherwise) - adopted main's boot/prototypes.js (server-enabled for SSR) Additionally fixes a latent Quasar v2 event-contract gap the merge review surfaced: 101 @input handlers and 43 :value bindings on Quasar form components renamed to @update:model-value / :model-value (Quasar v2 components no longer emit input or read value; the handlers were dead and several bindings one-way only). Verified: SPA + SSR builds pass; headless audit of 10 routes renders with zero Vue warnings. https://claude.ai/code/session_013pNZHMppjJ2iGVjxjHKkpQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
localStorageon drag release and restore them on reload, preserving DMs' preferred layout between sessions.hk-paneregistration with a sync local import inRunCampaign.vueso allSplitpaneschildren mount synchronously — async children caused splitpanes' equalize-on-add cascade to overwrite saved sizes with redistributed defaults on every reload.resizedevents that don't originate from a real user drag (defends against thecampaign.privatetoggle adding/removing the Share pane and triggering a runtime equalize).Test plan
lg; drag each of the 5 splitters, reload, confirm sizes are restoredleft-topdoesn't get overwritten with an equalized valuelocalStorage["dm-screen-panes-v1"]to invalid JSON / out-of-range value / unknown key; reload and confirm graceful fallback to defaultslegacy_campaign_layoutenabled both still render with their existing hardcoded sizes and write nothing to storage