-
Notifications
You must be signed in to change notification settings - Fork 3
Improve Harper Application Management with lockfile #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
abb78a3 to
ad4484c
Compare
01e4bc6 to
aac39e1
Compare
kriszyp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
One thing I am little confused by, we have a script to run integrations tests:
https://github.com/HarperFast/harper/pull/11/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R38
It looks like it is running different integration tests? Those still need to be pulled in and integrated with these tests?
|
Yes these are separate integration tests. The existing integration tests are the |
|
Moreover the |
9291f17 to
5cff21c
Compare
cb1kenobi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Taking a note from package managers, this PR adds a
harper-application-lock.jsonfile for tracking application installation. Now, if an application configuration is unchanged, it won't be reinstalled.based on #12