Skip to content

Conversation

@Ethan-Arrowood
Copy link
Member

@Ethan-Arrowood Ethan-Arrowood commented Oct 27, 2025

Taking a note from package managers, this PR adds a harper-application-lock.json file for tracking application installation. Now, if an application configuration is unchanged, it won't be reinstalled.

based on #12

@Ethan-Arrowood Ethan-Arrowood force-pushed the harper-application-lock branch from abb78a3 to ad4484c Compare October 27, 2025 21:05
@Ethan-Arrowood Ethan-Arrowood changed the base branch from main to general-repo-updates October 27, 2025 21:05
Base automatically changed from general-repo-updates to main October 28, 2025 17:06
@Ethan-Arrowood Ethan-Arrowood force-pushed the harper-application-lock branch from 01e4bc6 to aac39e1 Compare October 31, 2025 16:15
Copy link
Member

@kriszyp kriszyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!
One thing I am little confused by, we have a script to run integrations tests:
https://github.com/HarperFast/harper/pull/11/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R38
It looks like it is running different integration tests? Those still need to be pulled in and integrated with these tests?

@Ethan-Arrowood
Copy link
Member Author

Yes these are separate integration tests. The existing integration tests are the apiTests/ that run in sequence on their own Harper instance. Those already take so long to execute I didn't want to keep adding to it so I started this new folder. My next step was to merge the integration test workflows so they can all run "together" as part of the CI, but still be independently authored (and can be independently executed locally for faster debugging and iteration).

@Ethan-Arrowood
Copy link
Member Author

Moreover the integrationTests/apiTests/ are not independent. You can't really isolate any one test or test suite and get reliable runs. Some of the files depends on like tables being created from previous test files. I want to avoid more of that as it makes fixing tests really hard because you have to run the entire suite every time.

@Ethan-Arrowood Ethan-Arrowood changed the title Improve Harper Application Management by optimizing installation using lockfile Improve Harper Application Management Nov 4, 2025
@Ethan-Arrowood Ethan-Arrowood marked this pull request as ready for review November 4, 2025 16:34
@Ethan-Arrowood Ethan-Arrowood requested a review from a team November 4, 2025 16:34
@Ethan-Arrowood Ethan-Arrowood requested a review from a team as a code owner November 4, 2025 16:34
@Ethan-Arrowood Ethan-Arrowood force-pushed the harper-application-lock branch from 9291f17 to 5cff21c Compare November 4, 2025 23:40
@Ethan-Arrowood Ethan-Arrowood changed the title Improve Harper Application Management Improve Harper Application Management with lockfile Nov 4, 2025
Copy link
Contributor

@cb1kenobi cb1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Ethan-Arrowood Ethan-Arrowood merged commit 8e6e2b6 into main Nov 5, 2025
7 checks passed
@Ethan-Arrowood Ethan-Arrowood deleted the harper-application-lock branch November 5, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants