Merged
Conversation
fix: Build schemas and v1/v2.d.ts into builds
* Add basic read_log string filtering * Test every log element for filter match in read_log ...instead of concatenating them all together first. Thinking this should be more performant. * Use elapsed time to yield in read_log filtering * Yield to the event loop every 10 lines of log filtering
kriszyp
approved these changes
Jan 21, 2026
Ethan-Arrowood
approved these changes
Jan 22, 2026
Member
Ethan-Arrowood
left a comment
Ethan-Arrowood
left a comment
There was a problem hiding this comment.
Amazing! Thanks for taking up this process. I appreciate it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3 commits to sync this week (one was skipped b/c it wasn't relevant to this repo)
Note to self: Once this is merged, make sure the new
readLogtests get synced over. That test file only exists on theadd-unit-testsbranch as of now (and that branch doesn't have these changes that those tests depend on to pass).