Stop the profiler if aggregate period is not positive#190
Merged
Conversation
cb1kenobi
approved these changes
Mar 4, 2026
…alysis. node 24 was getting hung up
…-non-positive-integer
kriszyp
changed the title
cb1kenobi
approved these changes
Mar 5, 2026
heskew
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not exactly sure how this happens, but every once in a while the profiler will start with the default profiler time period and then later detect that it is disabled (due to a null or negative value). Passing in a negative value to
setTimeoutcauses the profiler to get stuck in high-frequency restarts which is a big problem. This breaks out of that.And I had to pull in Nathan's PR to get the tests to pass.