fix: Use jwt types to adjust the implementation slightly#211
Merged
Conversation
The only glaring rpbolem was with `algorithms: RSA_ALGORITHM`, where it expects an array, on (new) line 204. There are some cases where we may get back a string and not a JwtPayload too, but this gets us closer, at least. Plus, there were a lot of unnecessary awaits. The decodes, signs, and verifys are all synchronous.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
kriszyp
reviewed
Mar 11, 2026
kriszyp
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only glaring problem was with
algorithms: RSA_ALGORITHM, where it expects an array, on (new) line 204. It's possible the library allows that, but the types don't describe it, so it would work without this fix. But YMMV.There are some cases where we may get back a string and not a JwtPayload too, but this gets us closer, at least. Plus, there were a lot of unnecessary awaits. The decodes, signs, and verifys are all synchronous.