Conversation
kriszyp
force-pushed
the
sync-TLS-loading
branch
from
65297aa to
ce47dcc
Compare
DavidCockerill
approved these changes
Mar 18, 2026
kriszyp
changed the title
dawsontoth
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change/fix to yield asynchronously on search query (https://github.com/HarperFast/harper/blob/main/resources/search.ts#L349) had ramifications for making downstream consumers actually execute across multiple macro event turns. This led to a regression in using
createTLSSelectorfor replication, specifically it was possible to access thesecureContextswhile it was being loaded; after the map was cleared, but before values were added to it. It would be possible to continue to do this async, and replace the map at the end, but I didn't want to continue to fight the async and this seems simpler, more deterministic, and really the TLS reloading should be fast enough that sync is probably appropraite.