Merged
Conversation
dawsontoth
approved these changes
Mar 19, 2026
| try { | ||
| // Extract fields from first object if not provided | ||
| if (!fields && typeof chunk === 'object' && chunk !== null) { | ||
| fields = Object.keys(chunk); |
Contributor
There was a problem hiding this comment.
@DavidCockerill didn't you have an issue where the exported CSV from Studio had different headers based on your sort or results? Do I remember that right?
Member
There was a problem hiding this comment.
I did... I cant remember much more about it. In the end I think i just exported all the results without any filtering
Devin-Holland
approved these changes
Mar 19, 2026
heskew
reviewed
Mar 19, 2026
Member
There was a problem hiding this comment.
nit: need these json2csv mentions?
heskew
reviewed
Mar 19, 2026
| const registerFastifySerializers = fp( | ||
| function (fastify, opts, done) { | ||
| // eslint-disable-next-line require-await | ||
| // |
Member
There was a problem hiding this comment.
nit: still want a comment line here?
heskew
reviewed
Mar 19, 2026
| import { Transform } from 'json2csv'; | ||
| // TODO: Only load this if fastify is loaded | ||
| import fp from 'fastify-plugin'; | ||
| import { Transform } from 'stream'; |
heskew
approved these changes
Mar 19, 2026
Member
heskew
left a comment
heskew
left a comment
There was a problem hiding this comment.
another dep bites the dust 🙌
just a few real minor comments
DavidCockerill
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is deprecated (and loudly proclaims it when you
npm install harper).