Skip to content

Add the ability to define 'universal' headers, that can be used for l…#312

Merged
kriszyp merged 1 commit intomainfrom
universal-headers
Apr 2, 2026
Merged

Add the ability to define 'universal' headers, that can be used for l…#312
kriszyp merged 1 commit intomainfrom
universal-headers

Conversation

@kriszyp
Copy link
Copy Markdown
Member

@kriszyp kriszyp commented Apr 1, 2026

…icense information

@kriszyp kriszyp marked this pull request as ready for review April 1, 2026 04:23
@kriszyp kriszyp requested a review from a team as a code owner April 1, 2026 04:23
Copy link
Copy Markdown
Contributor

@dawsontoth dawsontoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do customer code can see the const and add headers to it? A set would be a bit cleaner, if I'm understanding things right.

@kriszyp
Copy link
Copy Markdown
Member Author

kriszyp commented Apr 1, 2026

Do customer code can see the const and add headers to it?

No, it is internal only. And yes, a Map would be more ergonomic/cleaner, but it is slower to iterate than an array (about 7ns vs 3ns). And since this is a part of every request, performance is important.

@kriszyp kriszyp merged commit 05aa4e9 into main Apr 2, 2026
22 checks passed
@kriszyp kriszyp deleted the universal-headers branch April 2, 2026 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants