Skip to content

fix type exports to actually include the root index.d.ts#331

Merged
Ethan-Arrowood merged 1 commit intomainfrom
fix/types-export
Apr 12, 2026
Merged

fix type exports to actually include the root index.d.ts#331
Ethan-Arrowood merged 1 commit intomainfrom
fix/types-export

Conversation

@Ethan-Arrowood
Copy link
Copy Markdown
Member

TypeScript basically strips *.d.ts files at build time so we should exclude the root index.d.ts from the build and since its already included in the package files list, we can reference it in the exports as the designated "."["types"] entry.

@Ethan-Arrowood Ethan-Arrowood requested a review from a team as a code owner April 10, 2026 16:26
Copy link
Copy Markdown
Contributor

@dawsontoth dawsontoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I did a npm run package locally and inspected the built bits to verify.

@dawsontoth dawsontoth requested a review from a team April 10, 2026 16:39
@Ethan-Arrowood Ethan-Arrowood merged commit 8c48c2f into main Apr 12, 2026
35 of 37 checks passed
@Ethan-Arrowood Ethan-Arrowood deleted the fix/types-export branch April 12, 2026 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants