Merged
Conversation
kriszyp
reviewed
Apr 11, 2026
Member
kriszyp
left a comment
kriszyp
left a comment
There was a problem hiding this comment.
The code generally looks good, I noted a potential issue with the expiresAt check, and I know this is waiting on the RocksDB release. And as David noted in the previous PR, it would be great to use the new integration testing API/framework, but definitely wouldn't block merging this, as this is pretty important to get in for functionality parity SRTL.
kriszyp
approved these changes
Apr 14, 2026
| logger.trace?.( | ||
| `Saving record with id: ${id}, timestamp: ${new Date(txnTime).toISOString()}${ | ||
| expiresAt ? ', expires at: ' + new Date(expiresAt).toISOString() : '' | ||
| expiresAt > 0 ? ', expires at: ' + new Date(expiresAt).toISOString() : '' |
Member
There was a problem hiding this comment.
Looks like there is a still a reference to expiresAt requiring greater than zero, although just a log trace.
Contributor
Author
There was a problem hiding this comment.
This log trace was the reason I messed with expiresAt at all. A zero/negative value makes no sense being passed into new Date().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated
delete_transaction_logs_beforeanddelete_audit_logs_beforeto share the same logic. Supports both LMDB and RocksDB. The latter has been marked as deprecated.Updated
read_audit_logto supportdatabaseparameter.schemastill supported.Updated scheduled transaction cleanup to purge RocksDB transaction logs.
Fixes #158, #159, and #166. Fixes CORE-2612.
Recreated from #275