Handle error in outstandingCommit promise#423
Merged
Conversation
Member
|
maybe rebase to main to fix those update.test.js/sql errors, and let's see how the unit tests look. |
kriszyp
approved these changes
Apr 29, 2026
Member
kriszyp
left a comment
kriszyp
left a comment
There was a problem hiding this comment.
Looks great, nice catch! Ironically I just fixed this same exact type of error recently here HarperFast/harper-pro@fea048c#diff-e707e24c4bc1646c60ac7da292c9707439ee0083f363f0433fda2f851c2b20d1R316
Ethan-Arrowood
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a transaction fails due to
ERR_BUSY, the retry mechanism returns a new promise from the error handler attached to thecommitResolutionpromise. However thefinally()on theoutstandingCommitstarts a new chain and the original rejected promise propagates the error tooutstandingCommit. This error has already been handled, but we need to explicitly squetch it so that we don't get an unhandled rejection.Supercedes #415