Sync from old repo 2025-12-03 by cap10morgan · Pull Request #52 · HarperFast/harper

cap10morgan · 2025-12-03T17:19:29Z

No description provided.

fix lockfile property spelling and prevent racecondition for applicat…

Fixes for cert verification integration tests only (no auth middleware…

…parated Keep multiple set-cookie headers separate

…a bad body

…ass on query to subscribe

Ensure HARPER_SET_CONFIG can override any other config source

Fix mergeHeaders, where set-cookie headers could get combined, and se…

Have deploy-component fail by default if a conflicting config entry exists (can be forced)

* Limit message size so we don't get messages rejected on the receiving side * Add request body size limits * Add test of too large of request body * Respond to too large of request body more politely * Update server/serverHelpers/contentTypes.ts Co-authored-by: Chris Barber <chris@harperdb.io> --------- Co-authored-by: Chris Barber <chris@harperdb.io>

Mostly just because my editor puts red squigglies underneath them haha

This will come back once we get the unit testing infrastructure ready in this repo.

Ethan-Arrowood

generally LGTM but lets get CI happy first

Ethan-Arrowood · 2025-12-03T17:57:26Z

.git-blame-ignore-revs

@@ -1,3 +1,4 @@
 # Format Commits
+84de82b25fff81f7b28c1a83789d1a9247fa73b4


I don't know if order matters, but I believe I've been appending to this file so far

package.json

.eslintrc.required.json

Ethan-Arrowood · 2025-12-04T17:08:11Z

package.json

 		"lint": "eslint .",
+		"lint:required": "eslint --no-config-lookup --quiet -c eslint.required.config.mjs .",


Is required referring to the no-undefined rule? Like why does this ruleset differ from the default one? When should I lint with lint vs lint:required?

We need those questions answered in contributing docs somewhere. Or we should be replacing the existing config with this one if we intend for it to be a check. My editor tells me about lint issues based on the default config, but doesn't pick this new one up. But we are using this new one for PR checks? It should be the one and only lint config then, right?

As this is a sync PR, this is all explained in the original PR from the old repo: https://github.com/HarperFast/harperdb/pull/3013

However, I'm happy to add some notes about it to the contributing docs in here.

The short version is that nothing else needs to change, this is just to allow us to gradually start enforcing some linter rules in CI over time (starting with no-undef). But we want the larger ruleset to continue applying in all other contexts. Eventually there should only be one ruleset that is enforced everywhere.

I plan to try to enable one of the disabled rules in the required config every week going forward (along with the necessary fixes to make it pass).

Proposed docs section added in e3da3da

Unfortunately that original PR is not available for anyone but us. I know we don't exactly have public contributors yet, but I'm intentionally trying to force us to be transparent. Any information hidden in the old private repo that is relevant must be bubbled up.

And don't worry about adding to these sync PRs - thats the point of them. Its not just cherry-picking commits, but also making sure they all work with the OSS version. Additional commits is 100% okay and expected even if they have changes.

And the info you added looks great. approving now! thank you for doing all of this.

Unfortunately that original PR is not available for anyone but us. I know we don't exactly have public contributors yet, but I'm intentionally trying to force us to be transparent. Any information hidden in the old private repo that is relevant must be bubbled up.

And don't worry about adding to these sync PRs - thats the point of them. Its not just cherry-picking commits, but also making sure they all work with the OSS version. Additional commits is 100% okay and expected even if they have changes.

Yeah, I'm 100% on board with all that. I just wasn't sure if you were asking for yourself or on behalf of the community, so was trying to cover both bases. :)

socket-security · 2025-12-04T19:51:22Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	graphql-http@1.22.4

View full report

kriszyp and others added 27 commits December 3, 2025 09:16

Only warn for no arg on get()

7a99384

Use lower frequency profiling

a52bb27

Cleanup, more comments

a06c710

Chris's typing mumbo jumbo

f729509

Merge pull request #2990 from HarperFast/fix-app-install

530e006

fix lockfile property spelling and prevent racecondition for applicat…

Merge pull request #2992 from HarperFast/certverifi-int-test-upd

56d7b82

Fixes for cert verification integration tests only (no auth middleware…

Merge pull request #2995 from HarperFast/CORE-2548/gotta-keep-them-se…

ee6d2d8

…parated Keep multiple set-cookie headers separate

Used a faster compression setting

839e70a

Merge branch 'release_4.6'

ecfbf80

Handle thrown plain objects correctly and properly report errors for …

3784f86

…a bad body

Update test to use loadAsInstance=false and fix connect to properly p…

9222498

…ass on query to subscribe

Merge pull request #3002 from HarperFast/set-config-over-all-others

9515bcc

Ensure HARPER_SET_CONFIG can override any other config source

Merge branch 'release_4.6'

bd09cc4

Merge pull request #3007 from HarperFast/CORE-2548/headers

abfba47

Fix mergeHeaders, where set-cookie headers could get combined, and se…

Merge pull request #3008 from HarperFast/default-config-doclink

a4c5224

Reset the restartRequired flag on restart, STUDIO-358

48ec75d

Ensure that we reset the resource cache when a transaction is committed

b4ee158

Merge pull request #3012 from HarperFast/CORE-2957/deploy-component

e8f2b46

Have deploy-component fail by default if a conflicting config entry exists (can be forced)

Merge branch 'release_4.6'

dfe7b10

fix: Restart 1/8th of the workers at a time (#3010)

c593ffa

Remove unused processManagement fns (#3017)

3bcff53

Update last synced commit in CONTRIBUTING.md

62c1b9b

Fix some nit-picky typos in CONTRIBUTING.md

966dc68

Mostly just because my editor puts red squigglies underneath them haha

Commit formatting fixes

84de82b

Add formatting fix commit to ignored revs

9c631b3

Remove unit test for now

6cde916

This will come back once we get the unit testing infrastructure ready in this repo.

kriszyp approved these changes Dec 3, 2025

View reviewed changes

Ethan-Arrowood reviewed Dec 3, 2025

View reviewed changes

Append latest ignored formatting rev

2ce6db5

cap10morgan added 3 commits December 3, 2025 15:05

Update lint:required config for eslint 9.x

a30b980

Fix issues caught by lint:required

8a93981

Disable package manager cache in lint-code workflow

fa03385

cap10morgan marked this pull request as ready for review December 3, 2025 22:51

cap10morgan requested review from a team as code owners December 3, 2025 22:51

Ethan-Arrowood reviewed Dec 4, 2025

View reviewed changes

Delete old .eslintrc.required.json config

e991395

Add a CONTRIBUTING section on formatting & linting

e3da3da

Ethan-Arrowood approved these changes Dec 4, 2025

View reviewed changes

Ethan-Arrowood merged commit ae82f1a into main Dec 4, 2025
22 checks passed

Ethan-Arrowood deleted the sync-12032025 branch December 4, 2025 20:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sync from old repo 2025-12-03#52

Sync from old repo 2025-12-03#52
Ethan-Arrowood merged 33 commits intomainfrom
sync-12032025

cap10morgan commented Dec 3, 2025

Uh oh!

Ethan-Arrowood left a comment

Uh oh!

Ethan-Arrowood Dec 3, 2025

Uh oh!

Uh oh!

Uh oh!

Ethan-Arrowood Dec 4, 2025

Uh oh!

cap10morgan Dec 4, 2025 •

edited

Loading

Uh oh!

cap10morgan Dec 4, 2025

Uh oh!

Ethan-Arrowood Dec 4, 2025

Uh oh!

Ethan-Arrowood Dec 4, 2025

Uh oh!

cap10morgan Dec 4, 2025

Uh oh!

socket-security bot commented Dec 4, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		@@ -1,3 +1,4 @@
		# Format Commits
		84de82b25fff81f7b28c1a83789d1a9247fa73b4

		"lint": "eslint .",
		"lint:required": "eslint --no-config-lookup --quiet -c eslint.required.config.mjs .",

Conversation

cap10morgan commented Dec 3, 2025

Uh oh!

Ethan-Arrowood left a comment

Choose a reason for hiding this comment

Uh oh!

Ethan-Arrowood Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Ethan-Arrowood Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

cap10morgan Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cap10morgan Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Ethan-Arrowood Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Ethan-Arrowood Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

cap10morgan Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

socket-security bot commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cap10morgan Dec 4, 2025 •

edited

Loading

socket-security bot commented Dec 4, 2025 •

edited

Loading