Sync 2025-12-08 #55
Merged
Sync 2025-12-08 #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriszyp
approved these changes
Dec 8, 2025
Member
|
In the future we should be skipping commits that don't do anything. I think I noticed some of these in the previous sync. Empty commits are pointless and could potentially be leaking private information. |
Member
Author
Yeah normally I do, but I had to interactively rebase this one to remove something else that snuck in and that's what changed it to an empty commit. Didn't seem worth the effort to go back and make it "skipped" at that point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Much less to sync this time :)