Integration tests improvements #69
Merged
+153
−119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rministically wait for it to start without arbitrary delay
dawsontoth
approved these changes
Jan 5, 2026
DavidCockerill
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the integration tests were running 4 processes to run Harper:
This PR greatly simplifies the process and speeds things up by simply starting the actual harper process. And directly killing it when it is done. And it also waits for the process to start and then continues, instead of using an arbitrary delay that is likely either too fast or too slow. This also preserves the process reference in the context (in case you want to check the PID or send a signal or something).