chore(deps): remove @datadog/pprof from core#880
Merged
Conversation
@datadog/pprof is only used by analytics/profile.ts, which lives in harper-pro, not core. Core has no direct import of it, so drop it from core's dependencies. It remains in the lockfile only as a transitive dev/peer dependency of the published `harper` package. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the @datadog/pprof package from the production dependencies in package.json and updates its classification, along with its sub-dependencies, to development and peer dependencies in package-lock.json. There are no review comments, so I have no feedback to provide.
Contributor
|
Reviewed; no blockers found. |
Member
Author
|
Syncing core on pro is kinda broken due to conflicting datadog versions, so fixing that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@datadog/pprofis only consumed byanalytics/profile.ts, which lives in harper-pro, not in core. Core has no directimport/requireof it (only stale comments in test utils that guard against its native-build errors).@datadog/pproffrom core's directdependenciesinpackage.jsonand the top-level lockfile entry.package-lock.jsononly as a transitive dev/peer dependency of the publishedharperpackage, which is expected.Why
core:syncjob in harper-pro to overwrite/downgrade harper-pro's pinned pprof version on every sync.Companion change
search()#250) that updatesbuild-tools/sync-core.shto preserve harper-pro's pinned@datadog/pprofversion across the core dependency sync.Test plan
🤖 Generated with Claude Code