fix: load harper lazily in CacheHandler to avoid worker conflicts#47
Merged
Conversation
The Next.js cacheHandler module is loaded by Next.js itself (via `require()` on the `cacheHandler` config path), not by Harper. With turbopack, that load happens inside a build worker thread. Importing `harper` at the top of CacheHandler.cts ran harper's module initialization in that worker thread, which tried to register native worker hooks process-wide — conflicting with the same registration already done by the Harper main process. The result was a stream of "Worker creator already registered" uncaught exceptions; the HTTP worker kept restarting until Harper gave up (`Thread has been restarted undefined times and will not be restarted`). Same load path also fires with webpack — Next.js's build init requires the cacheHandler path directly via Node's `require()`, which bypasses webpack `externals` and `serverExternalPackages`. With `harper` not present in the customer's node_modules, the build fails with MODULE_NOT_FOUND on `node_modules/@harperfast/nextjs/node_modules/harper`. Switch to the same pattern `plugin.ts` uses: import `harper` for types only, and read `databases` from `globalThis` at call time. The module now loads cleanly in any context, and methods short-circuit (return null / no-op) if `databases` isn't available — which is the correct fallback when there is no Harper runtime to talk to. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Next.js cacheHandler module is loaded by Next.js itself (via
require()on thecacheHandlerconfig path), not by Harper. With turbopack, that load happens inside a build worker thread. Importingharperat the top of CacheHandler.cts ran harper's module initialization in that worker thread, which tried to register native worker hooks process-wide — conflicting with the same registration already done by the Harper main process. The result was a stream of "Worker creator already registered" uncaught exceptions; the HTTP worker kept restarting until Harper gave up(
Thread has been restarted undefined times and will not be restarted).Same load path also fires with webpack — Next.js's build init requires the cacheHandler path directly via Node's
require(), which bypasses webpackexternalsandserverExternalPackages. Withharpernot present in the customer's node_modules, the build fails with MODULE_NOT_FOUND onnode_modules/@harperfast/nextjs/node_modules/harper.Switch to the same pattern
plugin.tsuses: importharperfor types only, and readdatabasesfromglobalThisat call time. The module now loads cleanly in any context, and methods short-circuit (return null / no-op) ifdatabasesisn't available — which is the correct fallback when there is no Harper runtime to talk to.