workflow: allow Read, Grep, Glob tools for Claude review#37
Merged
Conversation
First live review (PR #36) hit max_turns with 9 permission denials — Claude couldn't read CLAUDE.md or inspect code because the default v1 action tool policy denies everything not explicitly allowed. Adding --allowedTools Read,Grep,Glob gives read-only access sufficient for baseline review. Deliberately omitting Edit/Write/Bash — reviewer shouldn't need to modify files or run shell commands, and the implicit deny list keeps attack surface minimal. If a future review needs git history inspection, add Bash(git:*). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Member
Author
|
Both ci failures are known and being fixed (one by this pr) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First live review run on PR #36 hit
max_turnsat turn 9 withpermission_denials_count: 9. Claude couldn't readCLAUDE.mdor inspect code because the defaultclaude-code-action@v1tool policy denies everything not explicitly allowed, and we hadn't set an allowlist.Adding
--allowedTools Read,Grep,Globtoclaude_argsgives read-only access sufficient for baseline review:CLAUDE.md, tested files, files referenced in the diffDeliberately omitting
Edit/Write/Bash— a reviewer shouldn't need to modify files or run shell commands, and the implicit deny list keeps attack surface minimal. If a future review needs git history inspection, we can addBash(git:*).Test plan
Context
This is the first calibration learning from the pilot. PR #36 remains red on the
reviewcheck until this merges; its test-fix contents are independently validated (Node + Bun green there).