Change pkg_resources to importlib.resources#75
Merged
HarrisonKramer merged 2 commits intoHarrisonKramer:masterfrom Feb 18, 2025
Merged
Change pkg_resources to importlib.resources#75HarrisonKramer merged 2 commits intoHarrisonKramer:masterfrom
HarrisonKramer merged 2 commits intoHarrisonKramer:masterfrom
Conversation
Owner
|
I only see changes to the spot diagram code. Is it possible you referenced the wrong branch? |
Collaborator
Author
Yes, sorry for the inconvenience. Updated it now. |
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (65.00%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. @@ Coverage Diff @@
## master #75 +/- ##
==========================================
- Coverage 96.82% 96.59% -0.23%
==========================================
Files 105 105
Lines 6322 6337 +15
==========================================
Hits 6121 6121
- Misses 201 216 +15
|
Owner
|
No inconvenience at all. Thanks for making this change! |
HarrisonKramer
approved these changes
Feb 18, 2025
Owner
|
Looks good! Merging now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The library named pkg_resources kept giving warnings on the tests. It will be deprecated as stated in https://setuptools.pypa.io/en/latest/pkg_resources.html .
This PR includes switching from pkg_resources to importlib.resources, as suggested in the formerly given link.