Draft
Conversation
juni-purr
suggested changes
Nov 15, 2024
Contributor
juni-purr
left a comment
juni-purr
left a comment
There was a problem hiding this comment.
Very incomplete, has no buttons support, has bad practices and needs more refinement.
| import { Vec } from "@common/utils/vector"; | ||
| import $ from "jquery"; | ||
| import nipplejs, { type JoystickOutputData } from "nipplejs"; | ||
| import * as PIXI from "pixi.js"; |
Contributor
There was a problem hiding this comment.
please do not import everything from pixijs
Contributor
Author
There was a problem hiding this comment.
Done, now it only imports ticker
| shootOnRelease = false; | ||
| }); | ||
| } | ||
| const ticker = new PIXI.Ticker(); |
Contributor
There was a problem hiding this comment.
use Game class's pixi ticker
| const ticker = new PIXI.Ticker(); | ||
| ticker.stop(); | ||
| ticker.add(() => { | ||
| const gamepads = navigator.getGamepads(); |
Contributor
There was a problem hiding this comment.
if you use Game's pixi ticker, put this into its own method
juni-purr
reviewed
Nov 15, 2024
| this.turning = true; | ||
| const activePlayer = game.activePlayer; | ||
| if (game.console.getBuiltInCVar("cv_responsive_rotation") && !game.gameOver && game.activePlayer) { | ||
| game.activePlayer.container.rotation = this.rotation; |
Contributor
There was a problem hiding this comment.
isn't there a better way to do this in the Player class?
| const ticker = new PIXI.Ticker(); | ||
| ticker.stop(); | ||
| ticker.add(() => { | ||
| const gamepads = navigator.getGamepads(); |
Contributor
There was a problem hiding this comment.
do you really need to call this method every frame, is it required?
fix: only imported ticker instead of all of pixi.js
juni-purr
reviewed
Nov 15, 2024
| import $ from "jquery"; | ||
| import nipplejs, { type JoystickOutputData } from "nipplejs"; | ||
| import * as PIXI from "pixi.js"; | ||
| import { Ticker } from "pixi.js"; |
Contributor
There was a problem hiding this comment.
this is still wrong, use the Game update method
juni-purr
reviewed
Nov 16, 2024
also updated cute english (again)
Updated changelog. Bumped protocol version. Bumped package.json version number. Set mode to fall in constants. Map to fall in config.ts. Updated game bg. Updated embed bg. Updated github bg.
This reverts commit 29960d6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
*Not using requestAnimationFrame anymore