Changed default for split error re: weight when there is no rarity delimiter#95
Merged
HashLips merged 1 commit intoHashLips:mainfrom Oct 15, 2021
Merged
Conversation
On my first attempts to run this with my projects layers (note: not using rarity delimiter), the code would error with the stack trace that follows. This change made my code work, but this PR is to point out the issue more than to propose that this is the perfect solution.
```UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'split' of undefined
at cleanDna (/Users/christopherfoley/nft/hashlips_art_engine/src/main.js:54:25)
at /Users/christopherfoley/nft/hashlips_art_engine/src/main.js:151:22```
Contributor
Author
chrisninetyone
changed the title
This was referenced Oct 9, 2021
Closed
devdoge999
pushed a commit
to rira-university/rira-metadata-scripts
that referenced
this pull request
Jan 16, 2022
Changed default for split error re: weight when there is no rarity delimiter
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my first attempts to run this with my project's layers (note: not using rarity delimiter), the code would error with the stack trace that follows. This change made the code work, but this PR is to point out the issue more than to propose that this is the perfect solution.