Skip to content

feat: add nano contract class with serializer/deserializer methods #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pedroferreira1 merged 3 commits into from
May 29, 2023
Merged

feat: add nano contract class with serializer/deserializer methods #24

pedroferreira1 merged 3 commits into from
May 29, 2023

Conversation

@pedroferreira1
Copy link
Member

@pedroferreira1 pedroferreira1 commented May 26, 2023 •
edited
Loading

Acceptance Criteria

  • Create NanoContract class.
  • Add methods to serialize and deserialize the nano contract object.
  • Transaction mining service should be able to mine nano contract transactions with the methods in the class.

@pedroferreira1 pedroferreira1 requested a review from jansegre May 26, 2023 15:51
@pedroferreira1 pedroferreira1 self-assigned this May 26, 2023
@pedroferreira1 pedroferreira1 requested a review from msbrogli as a code owner May 26, 2023 15:51
msbrogli
msbrogli requested changes May 26, 2023
View reviewed changes
@pedroferreira1 pedroferreira1 force-pushed the feat/nano-contract-tx-serializer branch from 4ef07cc to 09e1c78 Compare May 27, 2023 03:08
msbrogli
msbrogli reviewed May 27, 2023
View reviewed changes
Copy link
Member

@msbrogli msbrogli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the first EVER public PR related to Nano Contracts! Great job, @pedroferreira1 ! \o/ \o/ \o/

@pedroferreira1 pedroferreira1 requested a review from msbrogli May 29, 2023 12:44
@pedroferreira1 pedroferreira1 merged commit 55de6c1 into dev May 29, 2023
@pedroferreira1 pedroferreira1 deleted the feat/nano-contract-tx-serializer branch May 29, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msbrogli msbrogli msbrogli approved these changes

@jansegre jansegre jansegre approved these changes

Assignees

@pedroferreira1 pedroferreira1

Labels

None yet

Projects

Hathor Network
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pedroferreira1 @msbrogli @jansegre