Potential fix for code scanning alert no. 1: Use of RSA algorithm without OAEP

[remdui]

Potential fix for https://github.com/HauntedMC/ProxyFeatures/security/code-scanning/1

In general, to fix this issue you should configure the RSA cipher to use OAEP padding rather than PKCS#1 v1.5 (or no padding). In Java, that means changing the transformation string from "RSA/ECB/PKCS1Padding" (or similar) to an OAEP-based transformation like "RSA/ECB/OAEPWithSHA-256AndMGF1Padding" (or at least "RSA/ECB/OAEPWithSHA-1AndMGF1Padding"), and then ensuring that the peer that encrypts the data uses the same OAEP parameters so decryption remains compatible.

For this specific code, the minimal change that preserves behavior as much as possible while improving security is to update the decrypt method in VotifierServer.java to use an OAEP transformation. Since we only see decryption and no custom AlgorithmParameterSpec being passed, the simplest and most interoperable improvement is to use the standard OAEP transformation string. For widest compatibility with existing Java-based senders that might switch to OAEP, we can use "RSA/ECB/OAEPWithSHA-1AndMGF1Padding", which corresponds to Java’s default OAEP parameters and matches the example in the background description. No additional imports are needed because we are still using javax.crypto.Cipher. The only code change required in the shown snippet is to update the argument to Cipher.getInstance(...) in the decrypt method.

Concretely:

• In src/main/java/nl/hauntedmc/proxyfeatures/features/votifier/server/VotifierServer.java, locate the decrypt method.
• Replace the transformation string "RSA/ECB/PKCS1Padding" with "RSA/ECB/OAEPWithSHA-1AndMGF1Padding".
• Keep the rest of the method intact so that callers and functionality remain unchanged aside from the padding scheme.

Suggested fixes powered by Copilot Autofix. Review carefully before merging.