add-git-commit-hash-in-build: fix several errors#77
Merged
markknol merged 1 commit intoHaxeFoundation:masterfrom Jan 24, 2017
Gama11:patch-3
Merged
add-git-commit-hash-in-build: fix several errors#77markknol merged 1 commit intoHaxeFoundation:masterfrom Gama11:patch-3
markknol merged 1 commit intoHaxeFoundation:masterfrom
Gama11:patch-3
Conversation
1) the return type `haxe.macro.ExprOf<String>` should be `haxe.macro.Expr.ExprOf<String>` 2) `Context.error()` was called without the necessary import or qualified name 3) the class was called `MyMacros` but accessed as `Version` later on
Member
Author
|
(this is why automated testing for the snippets would've been good :P) |
Member
|
I put bugs in each snippet to see which articles people actually use :p |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
haxe.macro.ExprOf<String>should behaxe.macro.Expr.ExprOf<String>Context.error()was called without the necessary import or qualified nameMyMacrosbut accessed asVersionlater on