chore: align log format with upstream implementation #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can happen when recording value above highest trackable to non-autoresizing histogram.
Differs from 'percentile' field for percentile iteration.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
==========================================
+ Coverage 92.60% 97.98% +5.38%
==========================================
Files 5 4 -1
Lines 1540 1631 +91
==========================================
+ Hits 1426 1598 +172
+ Misses 114 33 -81
Continue to review full report at Codecov.
|
hassila
approved these changes
Feb 14, 2023
Contributor
dimlio
force-pushed
the
align-log-format-with-upstream-implementation
branch
from
2917817 to
5a88631
Compare
hassila
approved these changes
Feb 14, 2023
Contributor
|
Still got "000" - open a different issue for that, or within the context of this one? |
Collaborator
Author
|
well, I made output identical to Java version |
dimlio
force-pushed
the
align-log-format-with-upstream-implementation
branch
from
5a88631 to
a4fbd3a
Compare
…tion Use formatting support from Foundation.
dimlio
force-pushed
the
align-log-format-with-upstream-implementation
branch
from
a4fbd3a to
01cfc97
Compare
dimlio
force-pushed
the
align-log-format-with-upstream-implementation
branch
from
01cfc97 to
760aac6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Align output of histogram percentile distribution with upstream Java implementation.
How Has This Been Tested?
Added unit tests.
Minimal checklist:
DocCcode-level documentation for any public interfaces exported by the package