Apply good practices in the project#147
Merged
Merged
Conversation
due to changes introduced in HeavyIonAnalysis#132
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer: in the PR #136 there was added a header
infra/HelperFunctions.hppwhich contains some functions (either AnalysisTree-specific or plain ROOT / c++) used in analysis tasks. It should be admitted that theinfrais not a proper place for such a header, whileexampleswould fit better. The reason why the header is placed ininfrais that these function are also useful for AnalysisTreeQA, which is not supposed to include headers fromAnalysisTree/examples.The mentioned header should not be included in any AnalysisTree / AnalysisTreeQA classes for the sake of generality (only at users' tasks) - so the
infra/HelperFunctions.hppcan be (re)moved at any time.infra/HelperFunctions.hppClassDefversion ofTrackandParticleclasses (see details in Issue #146)