Skip to content

Apply good practices in the project#147

Merged
lubynets merged 12 commits into
HeavyIonAnalysis:masterfrom
lubynets:dev
May 30, 2026
Merged

Apply good practices in the project#147
lubynets merged 12 commits into
HeavyIonAnalysis:masterfrom
lubynets:dev

Conversation

@lubynets
Copy link
Copy Markdown
Contributor

Disclaimer: in the PR #136 there was added a header infra/HelperFunctions.hpp which contains some functions (either AnalysisTree-specific or plain ROOT / c++) used in analysis tasks. It should be admitted that the infra is not a proper place for such a header, while examples would fit better. The reason why the header is placed in infra is that these function are also useful for AnalysisTreeQA, which is not supposed to include headers from AnalysisTree/examples.
The mentioned header should not be included in any AnalysisTree / AnalysisTreeQA classes for the sake of generality (only at users' tasks) - so the infra/HelperFunctions.hpp can be (re)moved at any time.

  • AnalysisTree classes are made independent on infra/HelperFunctions.hpp
  • Improved weights application (explicitly foresee case of weights == 1)
  • Got rid of compiler warnings, applied clang-formatting, followed clang-tidy suggestions
  • Updated ClassDef version of Track and Particle classes (see details in Issue #146)

@lubynets lubynets merged commit 12427b9 into HeavyIonAnalysis:master May 30, 2026
4 checks passed
@lubynets lubynets deleted the dev branch May 30, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant