Feat: payout account in payments tab (GEN-5159)#2916
Merged
Conversation
StylianosGakis
force-pushed
the
feature/payment-methods
branch
from
db622b0 to
ee424a5
Compare
Contains some more involved logic around retrying when there is an error
Should serve as a way to delegate some of the work without the ceremony with CI etc
Remove unused dependencies which were blocking this move Turn apollo-network-cache-manager also KMP as it was ready already
Add support for showing invoice option as the default payout option Add back snackbar success texts Fix swish basic numer validation
This one does not at the moment need to be MP
Only comes after checking for pay-in reminder as it takes precedence over payout
Matches the new API and makes it easier for people to copy-paste their number from their banking app
Add check for if there are any available methods, and still show it if none of the existing options are default
Replace `paymentInformation`
Only keep the relevant parts which allow us to determine whether to show or not show the payment details button
# Conflicts: # app/core/core-resources/src/androidMain/res/values-sv-rSE/strings.xml # app/core/core-resources/src/androidMain/res/values/strings.xml # app/core/core-resources/src/commonMain/composeResources/values-sv-rSE/strings.xml # app/core/core-resources/src/commonMain/composeResources/values/strings.xml # app/feature/feature-payments/src/main/kotlin/com/hedvig/android/feature/payments/navigation/PaymentsGraph.kt # app/feature/feature-payments/src/main/kotlin/com/hedvig/android/feature/payments/ui/memberpaymentdetails/MemberPaymentDetailsDestination.kt # app/member-reminders/member-reminders-ui/src/main/kotlin/com/hedvig/android/memberreminders/ui/MemberReminderCards.kt
panasetskaya
reviewed
May 5, 2026
panasetskaya
reviewed
May 5, 2026
panasetskaya
reviewed
May 5, 2026
panasetskaya
reviewed
May 5, 2026
panasetskaya
approved these changes
May 5, 2026
Contributor
panasetskaya
left a comment
panasetskaya
left a comment
There was a problem hiding this comment.
apart from that empty state, only some translations missing (mostly I think for payout method that are not implemented on BE yet), otherwise looks great 🚀
panasetskaya
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft. Backend is all mocked. UI is placeholders just as a simple start to start working on it