Skip to content

Conversation

@mcimerman
Copy link
Contributor

@mcimerman mcimerman commented Apr 22, 2025

Previous if conditions might increment argv, and the next conditions can dereference the dereference *(*argv) (instr_cmp) without checking.

Reproduce crash: for example: blkdump --offset 16

@le-jzr
Copy link
Contributor

le-jzr commented Apr 25, 2025

Thanks!
At first I thought it's a regression due to me changing str_cmp(), but turns out the previous implementation didn't handle null either.

@le-jzr le-jzr merged commit 0460377 into HelenOS:master Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants