making sessions a first class object #3595
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
This PR elevates sessions to first-class objects in Helicone by adding dedicated session fields to the request_response_rmt table structure.
- Added new columns
session_name,session_id, andsession_pathto the Clickhouse schema, extracted from properties that previously used 'Helicone-Session-*' keys - Added support for audio token tracking with new columns
prompt_audio_tokensandcompletion_audio_tokensin the request_response_rmt table - Implemented a three-step migration process (schema_45-47) that creates a new table structure, copies existing data with session fields extracted, and renames tables
- Added
is_deletedcolumn with default false value to support soft deletion functionality - Updated the RequestResponseRMT interface in
/valhalla/jawn/src/lib/db/ClickhouseWrapper.tsto include the new session and audio token fields
Greptile AI
6 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
| ADD COLUMN IF NOT EXISTS prompt_audio_tokens Int64 DEFAULT 0 | ||
| AFTER prompt_cache_read_tokens, | ||
| ADD COLUMN IF NOT EXISTS completion_audio_tokens Int64 DEFAULT 0 | ||
| AFTER completion_tokens; No newline at end of file |
Contributor
There was a problem hiding this comment.
style: Missing newline at end of file
Suggested change
| AFTER completion_tokens; | |
| AFTER completion_tokens; |
Comment on lines
+232
to
+234
| session_id: string; | ||
| session_name: string; | ||
| session_path: string; |
Contributor
There was a problem hiding this comment.
logic: The session fields are added to RequestResponseRMT but not to InsertRequestResponseVersioned interface. This inconsistency could cause type errors when inserting data.
Contributor
|
📝 Documentation updates detected! You can review documentation updates here |
Summary
⏳ 1 in progress |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.