Remove checked-in native dependencies, use packages#1632
Merged
Conversation
These were previously loose files checked into the repo.
Collaborator
Author
|
I have opened this PR as a draft because there are a handful of outstanding issues I intend to resolve:
|
1. Remove GeneratePathProperty; we don't need it 2. Stop double-including ZMusic and let the refs propagate
We're replacing the random loose libraries with proper Nuget packages; if any users hit issues with self-builds, then I really want to know what they are doing and would prefer that they just give us Github issues or something.
Collaborator
Author
|
Looks like the library in (2) is probably SDL2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of the work here actually takes place outside of this repository. The following repositories now have GitHub actions capable of building packages (see list below). Note that these are not automatically run and must be manually triggered, then their .nupkg outputs should be audited and uploaded manually; I chose to do this rather than auto-upload them because these are slow-changing packages and I want to be VERY deliberate about when we push updates.
.libor.afiles for native linking in AOT builds.