Fix for R6 Build issues#12
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
doug-helios
pushed a commit
that referenced
this pull request
Oct 2, 2025
smunini
added a commit
that referenced
this pull request
May 19, 2026
The audit suspected our advertised OperationDefinition canonical URLs might be wrong (standard FHIR convention puts no `$` in an OperationDefinition's `url` field — the `$` should only appear in the invocation path). Verified directly against the published SoF v2 spec on build.fhir.org: - OperationDefinition-ViewDefinitionRun.json → url ends in `$viewdefinition-run` - OperationDefinition-ViewDefinitionExport.json → url ends in `$viewdefinition-export` - OperationDefinition-SQLQueryRun.json → url ends in `$sqlquery-run` The SoF v2 spec deliberately uses the `$`-prefixed canonical URL form (deviates from standard FHIR convention, but that's what's published). Our code in `crates/sof/src/handlers.rs` and `crates/rest/src/handlers/capabilities.rs` already emits these exact strings. No code change required — item #12 closed as verified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #11