Skip to content

Multithread/pysof#13

Merged
smunini merged 171 commits into
mainfrom
multithread/pysof
Oct 6, 2025
Merged

Multithread/pysof#13
smunini merged 171 commits into
mainfrom
multithread/pysof

Conversation

@doug-helios
Copy link
Copy Markdown
Contributor

No description provided.

* feat/uv: complete MVP packaging docs and setup

* feat: add ci for python build

* feat: move the ci for python

* fix: update lock

* fix: update readme for macos and runners selfhosted

* tech debt: remove CI momentarly
* feat/uv: complete MVP packaging docs and setup

* feat: add ci for python build

* feat: move the ci for python

* fix: update lock

* fix: update readme for macos and runners selfhosted

* tech debt: remove CI momentarly
* feat: first iteration of bindings

* feat: first binding completed

* feat: switch build to maturin

* feat: complete the core functions

* feat: add tests for content types

* docs: update readme for v1

* feat: multiple engine support
* feat: first iteration of bindings

* feat: first binding completed

* feat: switch build to maturin

* feat: complete the core functions

* feat: add tests for content types

* docs: update readme for v1

* feat: multiple engine support
* feat: add pipe and script to build wheels locally

* feat:split pythonc ci steps

* fix:remove rust step

* fix: orchestrate workflow for ci at python

* fix: workflow release, removed PyPI for a bit

* tech debt: remove windows build temp

* fix: unify setup venv

* fix: split python ci/cd

* fix: remove deprecated pipes

* fix: optimize venv use

* fix: venv path

* fix: test coverage

* fix: add maturin

* fix: install maturin?

* fix: add rust toolchain

* fix: linter issues

* fix: linter target path

* fix: path for formats and linters

* fix: lint and checker target

* fix: last iter

* fix: args paths

* checkpoint 1
* feat: add pipe and script to build wheels locally

* feat:split pythonc ci steps

* fix:remove rust step

* fix: orchestrate workflow for ci at python

* fix: workflow release, removed PyPI for a bit

* tech debt: remove windows build temp

* fix: unify setup venv

* fix: split python ci/cd

* fix: remove deprecated pipes

* fix: optimize venv use

* fix: venv path

* fix: test coverage

* fix: add maturin

* fix: install maturin?

* fix: add rust toolchain

* fix: linter issues

* fix: linter target path

* fix: path for formats and linters

* fix: lint and checker target

* fix: last iter

* fix: args paths

* checkpoint 1
* feat: enable wheel artifact

* fix: remove restrictive branches, trigger on py-CI finish

* checkpoint?

* checkpoint pr

* Revert "checkpoint pr"

This reverts commit b6828d1.

* fix:add feture branch for testing

* change if for trigger
* feat: enable wheel artifact

* fix: remove restrictive branches, trigger on py-CI finish

* checkpoint?

* checkpoint pr

* Revert "checkpoint pr"

This reverts commit b6828d1.

* fix:add feture branch for testing

* change if for trigger
@smunini smunini force-pushed the multithread/pysof branch from 38763d9 to 5e0cb3c Compare October 2, 2025 20:50
@doug-helios doug-helios force-pushed the multithread/pysof branch 2 times, most recently from cf3c20d to c9b9163 Compare October 2, 2025 21:37
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
@smunini smunini force-pushed the multithread/pysof branch from d000767 to 038139c Compare October 4, 2025 20:45
@smunini smunini merged commit e4e594f into main Oct 6, 2025
11 checks passed
@doug-helios doug-helios deleted the multithread/pysof branch October 10, 2025 15:58
smunini added a commit that referenced this pull request May 19, 2026
The SoF v2 spec binds `_format` to
`https://sql-on-fhir.org/ig/ValueSet/OutputFormatCodes` with
`extensible` strength. Both impls already accept the spec codes
(csv/ndjson/parquet/json + fhir for $sqlquery-run on HFS REST) plus
some permissive MIME aliases, but neither declared the binding in
their capability advertisement. Conformance audit tools couldn't
discover it without dereferencing the OperationDefinition.

- `/$sql-on-fhir-capabilities` on both binaries now publishes an
  explicit `formatBinding` parameter pointing at the spec ValueSet
  and naming the `extensible` strength.
- Spec strength is `extensible`, so we don't hard-reject unknown
  codes; the declaration is advisory metadata that audit tools can
  find without indirection.

Tests:
- `test_sof_capabilities_endpoint` (sof-server integration) extended
  to assert the `formatBinding` block, its `valueSet` URI, and its
  `extensible` strength.
- `test_sof_capabilities_declares_format_binding` (HFS REST
  integration) asserts the same shape on the HFS REST side.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants