Feature/added fhir documentation#14
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
doug-helios
pushed a commit
that referenced
this pull request
Oct 2, 2025
doug-helios
pushed a commit
that referenced
this pull request
Oct 2, 2025
smunini
added a commit
that referenced
this pull request
May 19, 2026
…14) Per the SoF v2 spec, the `header` parameter "applies only when csv output is requested." Spec gives no requirement to reject it on other formats. sof-server's body-parameter branch was returning 400 with "Header parameter only applies to CSV format" — stricter than the spec. - `crates/sof/src/handlers.rs` body-only branch: when `header` is supplied in the body but the negotiated `_format` isn't CSV, leave the validated format untouched (the `header` is advisory; ignore it) instead of erroring. - `crates/sof/tests/common/mod.rs` stub mirrors the lenient behavior. - `parse_content_type` already handled this correctly internally (only applies `header_param` when content-type == text/csv); this removes the early-return that was rejecting before the mapping ran. Tests: - `test_header_parameter_without_format_is_ignored_on_non_csv` (renamed from `test_header_parameter_without_format`) now asserts 200 + JSON response, matching the new lenient behavior. - `test_csv_header_parameter_with_non_csv_format` already expected the lenient behavior and continues to pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.