ci: install patchelf via pip instead of build-system requirements#16
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
smunini
added a commit
that referenced
this pull request
May 19, 2026
`helios_sof::run_view_definition_with_options` already applies `_limit` at the structured-row level (via `apply_pagination_to_result`) before serialization. sof-server's handler then called `apply_result_filtering(output, &validated_params)` on the serialized bytes — which re-parsed, re-truncated, and re-serialized to produce identical output. Fragile in three ways: - JSON path re-parsed + re-serialized the entire record array. - NDJSON path re-parsed every line as JSON. - CSV path's line-split truncation assumed no embedded newlines in quoted fields. - Drop the `apply_result_filtering` call in `crates/sof/src/handlers.rs`. - Delete the dead helper chain in `crates/sof/src/models.rs`: `apply_result_filtering`, `apply_json_filtering`, `apply_csv_filtering`, `apply_pagination_to_records`, `apply_pagination_to_lines`. - Remove the two unit tests that exercised those helpers; end-to-end `_limit` behavior is still exercised by the HTTP-layer tests via the row-level pass. Pure code-quality cleanup — no spec or behavior changes. All sof test suites pass unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The key point is that the Install patchelf (Linux) step is correctly skipped on Windows because of the conditional if: runner.os == 'Linux'. This means Windows builds should work fine now that we removed patchelf from
pyproject.toml's build-system.requires.