Hotfix/support all engines#9
Merged
Merged
Conversation
doug-helios
added a commit
that referenced
this pull request
Oct 2, 2025
* feat: enable all feature on release * fix: release args --------- Co-authored-by: dougc95 <dougcr95@gmail.com>
smunini
added a commit
that referenced
this pull request
May 19, 2026
Per the SoF v2 spec, "invalid ViewDefinition or processing failure" maps to 422 Unprocessable Entity. HFS REST already does this. sof-server had a stray special case in `parse_view_definition_for_version` that mapped `SofError::InvalidViewDefinition → ServerError::BadRequest` (400), out of sync with the rest of the run pipeline (which already returned 422 via the default `From<SofError>` impl). - Remove the special case in `parse_view_definition_for_version`; `?`-conversion via `From<SofError>` routes through `ProcessingError` → 422. - Update the common.rs test stub's serde-deserialize-error mapping to match (was 400; now 422). Tests: - `test_invalid_view_definition_maps_to_422` (in-handler unit) feeds a type-mismatched select to `parse_view_definition_for_version`, confirms the returned ServerError is `ProcessingError`, and renders it via `into_response` to assert the HTTP status is 422. - `test_invalid_view_definition_returns_422` (integration) POSTs the same bad body through the full handler and asserts the response status is 422 with an OperationOutcome.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.