Skip to content

Conversation

@catsiller
Copy link

@catsiller catsiller commented Apr 23, 2019

JIRA: surf-1624

LGTM's

  • Dev LGTM
  • Zoom LGTM

When comparing the screenshots below, Dirty (in the after screenshots) should replace the Changed and Touched (in the before screenshot). Invalid styles should match.

Before

test page before screenshot

After

test page after screenshot

@HelixUI
Copy link
Contributor

HelixUI commented Apr 23, 2019

Deploy preview for helix-ui ready!

Built with commit 271293c

https://deploy-preview-483--helix-ui.netlify.com

@catsiller catsiller changed the title fix(Checkbox): fix and refactor Checkbox refactor(Checkbox): phase 2.5 CSS Refactoring Apr 23, 2019
@catsiller catsiller changed the title refactor(Checkbox): phase 2.5 CSS Refactoring refactor(Checkbox): phase 2.5 CSS refactoring Apr 23, 2019
@catsiller catsiller force-pushed the surf-1624-checkbox-phase-2.5 branch 2 times, most recently from a6df0de to ad578c9 Compare April 23, 2019 19:38
@catsiller catsiller force-pushed the surf-1624-checkbox-phase-2.5 branch from ad578c9 to 271293c Compare April 23, 2019 19:42
Copy link
Contributor

@CITguy CITguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev LGTM

Copy link
Member

@100stacks 100stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Async LGTM

@catsiller catsiller merged commit a3e6317 into master Apr 23, 2019
@catsiller catsiller deleted the surf-1624-checkbox-phase-2.5 branch April 23, 2019 20:12
@CITguy CITguy added this to the v0.16.0 milestone Apr 23, 2019
@CITguy CITguy added the :shipit: shipped label Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants