Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

0.5.8-pre#99

Merged
oracle58 merged 7 commits intodevfrom
of
Jul 19, 2019
Merged

0.5.8-pre#99
oracle58 merged 7 commits intodevfrom
of

Conversation

@oracle58
Copy link
Copy Markdown
Contributor

  • Refactoring related to (toString() for hash objects #83)
  • Refactoring of hbytes (=hex bytes), as naming was not really optimal. IOTA's trits are analogue to our bytes, while their trytes are analogue to our hex string format. We should refer to our counterpart to trytes as txHex, txString or transactionString, and counterpart to trits, as: txBytes or simply bytes.
  • attachToTangle, storeTransactions and broadcastTransactions now take param "tx" instead of "hbytes".
  • Cleanup and removal of duplicate code in converter

@oracle58 oracle58 added Refactor refactoring related. API api related labels Jul 19, 2019
@oracle58
Copy link
Copy Markdown
Contributor Author

oracle58 commented Jul 19, 2019

Codecov Report

Merging #99 into dev will increase coverage by 0.56%.
The diff coverage is 36.76%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev      #99      +/-   ##
============================================
+ Coverage     40.13%   40.69%   +0.56%     
+ Complexity     1062     1050      -12     
============================================
  Files           160      159       -1     
  Lines          7677     7527     -150     
  Branches        956      917      -39     
============================================
- Hits           3081     3063      -18     
+ Misses         4246     4115     -131     
+ Partials        350      349       -1
Impacted Files Coverage Δ Complexity Δ
src/main/java/net/helix/hlx/crypto/Winternitz.java 70% <ø> (-0.91%) 25 <0> (-3)
...x/hlx/service/stats/TransactionStatsPublisher.java 31.25% <ø> (+0.63%) 3 <0> (ø) ⬇️
src/main/java/net/helix/hlx/HLX.java 0% <ø> (ø) 0 <0> (ø) ⬇️
src/main/java/net/helix/hlx/model/Hash.java 100% <ø> (ø) 1 <0> (ø) ⬇️
src/main/java/net/helix/hlx/utils/Converter.java 16.66% <0%> (+6.02%) 1 <0> (-6) ⬇️
...lx/service/snapshot/impl/SnapshotProviderImpl.java 19.56% <0%> (ø) 13 <0> (ø) ⬇️
...lix/hlx/service/tipselection/impl/WalkerAlpha.java 13.72% <0%> (ø) 1 <0> (ø) ⬇️
...va/net/helix/hlx/network/TransactionRequester.java 58.73% <0%> (ø) 17 <0> (ø) ⬇️
...x/service/milestone/impl/MilestoneServiceImpl.java 5.92% <0%> (ø) 4 <0> (ø) ⬇️
...n/java/net/helix/hlx/zmq/MessageQProviderImpl.java 0% <0%> (ø) 0 <0> (ø) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 602cd0a...f4d00a2. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

API api related Refactor refactoring related.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants