Skip to content

154 idorder is not stored with the table#159

Merged
Lucaslgd02 merged 7 commits intodevfrom
154-idorder-is-not-stored-with-the-table
May 22, 2025
Merged

154 idorder is not stored with the table#159
Lucaslgd02 merged 7 commits intodevfrom
154-idorder-is-not-stored-with-the-table

Conversation

@Lucaslgd02
Copy link
Copy Markdown
Contributor

Describe your changes

Add orderId to tables

How to test the feature

Select a table
Make an order and submit it
The orderId is now linked to the corresponding table

Issue ticket number and link

Closes #154

Checklist before requesting a review

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have performed a self-review of my code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Documentation has been updated as required
    If a single item in this checklist is not checked, the pull request cannot be accepted

@Lucaslgd02 Lucaslgd02 self-assigned this May 16, 2025
@Lucaslgd02 Lucaslgd02 linked an issue May 16, 2025 that may be closed by this pull request
@Lucaslgd02 Lucaslgd02 enabled auto-merge May 16, 2025 06:17
@Lucaslgd02
Copy link
Copy Markdown
Contributor Author

Requires Back-End PR 151 to be accepted beforehand

@JulesGresset
Copy link
Copy Markdown
Member

This is not what the issue is about.
The orderId is already send by the backend to the POS with the /pos_config route called on the loading page where the data about the table is stored in the local storage, but not the orderId.
The issue is about adding the orderId in the local storage on loading.

auto-merge was automatically disabled May 16, 2025 17:42

Pull request was closed

@Lucaslgd02 Lucaslgd02 reopened this May 21, 2025
Copy link
Copy Markdown
Member

@JulesGresset JulesGresset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature works as intended, just a small modification needed to avoid multiple call to the back-end.

Comment thread src/Components/CurrentCommand/CurrentCommand.js Outdated
@Lucaslgd02 Lucaslgd02 requested a review from JulesGresset May 22, 2025 21:45
@Lucaslgd02 Lucaslgd02 enabled auto-merge May 22, 2025 21:45
@Lucaslgd02 Lucaslgd02 merged commit 1e9ceb1 into dev May 22, 2025
8 checks passed
@Lucaslgd02 Lucaslgd02 deleted the 154-idorder-is-not-stored-with-the-table branch May 22, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

idOrder is not stored with the table

2 participants