Refactor CommandesAPI to return response and add error handling#4
Closed
WillyReyno wants to merge 3 commits intoHelloAsso:mainfrom
Closed
Refactor CommandesAPI to return response and add error handling#4WillyReyno wants to merge 3 commits intoHelloAsso:mainfrom
WillyReyno wants to merge 3 commits intoHelloAsso:mainfrom
Conversation
Took inspiration from PaiementsAPI to complete what was missing here
Updated return type annotation for the method organizationsOrganizationSlugFormsFormTypeFormSlugItemsGet.
Author
|
I'm closing this pull request for now as I found more and more missing data from the endpoint which makes it nearly unusable. I will open an issue with a comparison. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Took inspiration from PaiementsAPI to complete what was missing here. See #1
There's still an issue with
with_detailsparam which is set to boolean and then serialized as an int from the following code:The API returns the following error
Workaround is to force "true" or "false" as string in organizationsOrganizationSlugFormsFormTypeFormSlugItemsGet