[Feature] Map Collection Support #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hopeman15
commented
Feb 2, 2022
forge-core/src/main/kotlin/io/github/hellocuriosity/ModelForge.kt
Outdated
Show resolved
Hide resolved
hopeman15
force-pushed
the
feature/map-provider
branch
from
7775d4b to
a4701d3
Compare
Contributor
Author
|
@nxtstep So this is still open and the only thing that makes sense to me right now is to not force the map to reach size, specifically since we don't currently have a way to pass said size to generate a map. WDYT? in any case would love your opinion and a review at your leisure 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds support for
Mapcollection type and closes #143.Review checklist