Fix fallback font chain not persistence when specified weight#116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now if the requested font with that weight is not available it will start looking in fallback chain. This also applied in the icon usage too since our icon usage built on top of font renderer. So if you render mix of normal text and icon (using
char.ConvertFromUtf32) with "bold" weight, in the icon part it will finding the "MaterialIcon-Bold" that we don't have since we only have regular, this PR make the fallback more weight-tolerant by make it look for regular weight instead too.Also since I use mix of icon and text in
SpriteTextso I add a new extension forIconUsagefor make my sanity better inchar.ConvertFromUtf32everywhere.