Make sidebar donate link optional?

[vitorio]

Step 1: Please describe your environment

• ZeroNet version: 0.6.3
• Operating system: OS X 10.11, Windows 10
• Web browser: Safari, Chrome, Edge
• Tor status: not available on Mac/available on Windows
• Opened port: yes

Step 2: Describe the problem:

As a site owner, I'd like to be able to remove the "Donate" link in the sidebar for my site.

There doesn't appear to be a way to do this through the ZeroFrame API, perhaps it could be added as an optional flag in content.json? Something like:

"donate": false

or

"hide_donate_links": true

?

[Thunder33345]

what sites or donate button are you talking about?

i have used zeronet without noticing what the "donate button" is please show a screenshot or so?

[vitorio]

@Thunder33345 If you pull open the right sidebar by dragging the zero icon in the upper right to the left, you'll see a "Donate" link if you scroll the sidebar all the way to the bottom. It's visible on all sites, and I'd like it to not be there for my own. (Note that it won't do anything if you don't have a Bitcoin application set up.)

[anoadragon453]

The ability to remove it and/or change it would be nice.

[Thunder33345]

well the bitcoin address is the site address, the site private key
the same key you used to access/edit the site
thus you already have a bitcoin address believe it or not

[anoadragon453]

Yes, but some people prefer to use their main btc address which may already be verified by a WoT.

…

On 07/01/2018 12:44 PM, Thunder33345 wrote: well the bitcoin address is the site address, the site private key the same key you used to access/edit the site thus you already have a bitcoin address believe it or not — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1467 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABR7mPNHVzdUIh4gvvP7cZuylXwZ5p_zks5uCLYrgaJpZM4U-LLN>.

[Thunder33345]

the site's address is always site owner, thus anyone can reasonably expect that if i donate to 1HeLLo4uzjaLetFx6NH3PMwFP3qbRbTf3D the owner of that site can be able to withdraw it

and there's nothing stopping you from donating to any site address
here's an example of ZeroHello's wallet

Right, but some people don't want to have to import every current and new zite. They just want to use one address for donating for everything.

[vitorio]

So extending my original proposal, then, perhaps:

By default, the donate link exists, and it shows the site address against a Bitcoin URL handler.

If content.json contains a key of: "donate": false or "donate": "", it does not display the site address or link.

If content.json contains a key of: "donate": "1...", where that value passes a Bitcoin address validation, it treats it as a Bitcoin address and shows it against a Bitcoin URL handler.

If content.json contains a key of "donate": "http://..." or "donate": "https://...", where those values are strings beginning with "http://" or "https://", it treats it as a URL and shows only the "Donate" button linking to that.

If content.json contains a key of donate with a value string with any other contents, it displays it as a block of text, suitable for site owners to provide alternative donation instructions.

Thoughts?

[Thunder33345]

actually that's not bad proposal, adding customizability is a +

BUT what if someone want to use another cryptocurrency
say Ethereum, Bitcoin Cash. Doge or so on?
i think begin amongous and somehow support all crypto will be nice

why not even allow text like "Donate to ETH(insert address) BCH(insert address)"
when click it will show that as popup

[vitorio]

To be clear about my use case for this: in the US, having evidence of a profit motive can be the difference between a civil charge and criminal charge under the DMCA. Being able to remove the "Donate" link and signal that you're not distributing content for financial gain may make it safer to do so.