Added /ignorelist command#189
Merged
Merged
Conversation
BlitzOffline
requested changes
Feb 1, 2023
Member
BlitzOffline
left a comment
BlitzOffline
left a comment
There was a problem hiding this comment.
This is mostly alright. I have made some comments on spelling or other small stuff like that.
The single big thing I can't approve on yet is the way you get the player names from UUIDs. As mentioned in another comment, I have seen servers having performance issues because of these calls being made en masse. I will wait for other's input on the mater (including yours if you have some)
BlitzOffline
requested changes
Feb 2, 2023
BlitzOffline
approved these changes
Feb 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #183