Reworked the mention system#51
Merged
Merged
Conversation
- Added permissions to block mentions coming to user (global or personal) - Added permission to override that block - Fixed personal mentions only showing to the receiver and not the sender as well
This is to stop mentions from working in the actual format and only in messages but this also means in the future we can somewhat easily add relational placeholder support(this requires a lot more thinking)
Starmism
approved these changes
Apr 20, 2022
lucyydotp
approved these changes
Apr 20, 2022
Kqliber
approved these changes
Apr 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's still a couple problems with the mention system however:
I don't know if I'll get a solution in this PR but if you guys have ideas please share
Forgot to mention that this closes #50