Sprint 2 batch 3: frontend error/not-found + a11y on auth forms#123
Merged
Conversation
App Router didn't have an error.tsx or a not-found.tsx, so any uncaught render error fell back to Next's built-in screen and any missing route returned the framework default. Both now render a calm branded fallback. error.tsx surfaces the digest Next attaches to production errors so a user can quote it when reporting an issue. Form labels in the auth flows (login, register, forgot-password, reset-password) had a className but no htmlFor, so the label/input association was broken — screen readers and password managers couldn't pair them. Added id + name + autoComplete on every input in those flows, with the matching htmlFor on each label. The deeper dashboard forms (settings, connectors editor) will be cleaned up in the dedicated UI sprint.
keysersoft
force-pushed
the
keysersoft/frontend-a11y
branch
from
5386c3e to
390cd04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
App Router was missing the two error fallbacks; the auth forms had broken label/input pairing.
error.tsx
Renders for any uncaught exception inside an App Router segment that hasn't installed its own. Surfaces the digest Next attaches in production so a user can quote it when reporting a bug, plus a retry button and a link back to the dashboard.
not-found.tsx
Branded 404 instead of the framework default.
Auth a11y
Login, register, forgot-password, reset-password forms had `Email` with no `htmlFor` and `` with no `id` — so screen readers and password managers couldn't associate them. Fixed: every input now has `id` + `name` + `autoComplete`, every label points to it via `htmlFor`. Settings, connectors editor and other deeper forms intentionally left for the dedicated UI sprint.
Test plan