Sprint 2 batch 4: optional pagination on list endpoints#124
Merged
Conversation
Both /api/connectors and /api/mcp-servers used to do an unbounded findMany on every call. Add a shared PaginationQueryDto (limit ≤ 200, offset ≥ 0) and an optional ?limit=&offset= on each route. The absence of either parameter keeps the existing behaviour, so the frontend, smoke tests, and any external client keep working without change. Smoke test: 12/12 passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`/api/connectors` and `/api/mcp-servers` used to do an unbounded `findMany` on every call. Adds a shared `PaginationQueryDto` (`limit` 1..200, `offset` ≥ 0, both validated by class-validator) and an optional `?limit=&offset=` on each route.
The absence of either parameter keeps the existing behaviour, so the frontend, smoke test, and any external client keep working without change. We don't return a `{ items, total, … }` envelope yet (would be a breaking change for existing callers); when we do, it will go behind a `?paginated=true` flag or under a new versioned route.
Test plan