Sprint 3 batch 4: settings page migrated to toast + a11y htmlFor#132
Merged
Conversation
settings/page.tsx — the most-used dashboard form — now:
- has htmlFor + matching id + autoComplete on every input/label pair
in the Profile and Change Password sections, so screen readers and
password managers pair them correctly.
- emits success/error toasts via useToast() instead of the ad-hoc
setProfileMsg / setPasswordMsg + setTimeout fade-out. The text-state
is kept around so the inline aria-live region in the form still
surfaces the same message — toasts are additive, not a replacement,
until every consumer is migrated.
Other settings/* pages (organization, admin, users, roles, license)
still use the older pattern; they will be migrated incrementally
without breaking anything because useToast() is a no-op outside the
provider tree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
settings/page.tsx (Profile + Change Password sections) gains
htmlFor+ matchingid+autoCompleteon every input, and emits toast notifications viauseToast()on success/failure instead of the ad-hocsetMsg+setTimeoutpattern. Other settings/* pages keep their existing inline message UI for now —useToast()is a no-op outside the provider tree, so partial migration is safe.