Connector healthcheckPath + classified test errors (#3)#165
Merged
Conversation
…t errors
Before this, POST /api/connectors/:id/test always hit baseUrl + '/'.
APIs without a root handler returned 404 and the UI flashed red even
though the connector was fine. We also couldn't tell 'wrong path' from
'wrong credentials' or 'network down' — they all looked the same.
Schema:
- new Connector.healthcheckPath String? column (additive migration)
Parser:
- new OpenApiParser.parseSpec / parseSpecFromUrl return { tools,
healthcheckPath? }. parse() / parseFromUrl() keep their old shape
for back-compat.
- detectHealthcheckPath: tries /health, /healthz, /_health, /ping,
/status first; falls back to the first non-parametric GET with no
required params.
Service:
- testConnection() now uses connector.healthcheckPath when set and
returns a 'kind' classification: ok | auth_failed (401/403) |
not_found (404, with hint to set healthcheckPath) | unreachable
(DNS/SSRF/timeout) | unsupported | error.
Controller:
- both import flows (import-spec, import) write the detected
healthcheckPath when the user hasn't already set one.
- CreateConnectorDto / UpdateConnectorDto expose the new field.
Frontend:
- connector detail page: edit form has a Healthcheck path input with
hint; the test result banner colours and labels by kind (auth
rejected, not found, unreachable, error).
- api.ts client typed for the new response shape.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
`POST /api/connectors/:id/test` always hit `baseUrl + '/'`. APIs without a root handler returned 404 and the UI flashed red even when the connector was fine. We also couldn't distinguish:
They all surfaced as the same generic failure.
Changes
Schema (additive migration)
Parser
Service
Controller
Frontend
Test plan