fix(sendcloud): require to_country to avoid 14s 'all carriers' calls#274
Merged
Conversation
…calls Telemetry showed sendcloud_list_shipping_methods running for 14.5s in production — info@siliconesandmore.com called it with only `from_country: NL` and no destination, so Sendcloud returned every shipping method for every country (thousands of rows, no server-side filter). Fix: add to_country to the JSON Schema required[] list and rewrite the description to be loud about the consequence of omitting it. Even without the schema enforcement the LLM was already passing from_country, so it clearly was reading the descriptions; making the new copy explicit + flagging required[] should be enough. This is a soft breaking change for any agent that was relying on the 'list everything' behavior — but in 48h of production data that was 0 of 24 Sendcloud calls. The other Sendcloud tools (list_parcels, get_parcel) returned in 140-251ms; only this one endpoint had the unscoped-query foot-gun.
keysersoft
force-pushed
the
fix/sendcloud-shipping-methods
branch
from
6529656 to
4baa7a8
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
sendcloud_list_shipping_methodsran for 14.5s in production today. The user passed onlyfrom_country: NLso Sendcloud returned every method for every country worldwide. The other 23 Sendcloud calls in the same 48h window were 140-251ms — only this endpoint had the unscoped-query foot-gun.Fix
to_countryto the JSON Schemarequired[]list.The LLM already follows description hints reasonably well (it passed from_country without prompting), so the combined fix should drop p99 for this tool from 14s back to <1s.
Test plan