release: v0.28.5 — TP-181/183/184/185 bug fixes#535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release v0.28.5
Bundles four bug fixes that landed since v0.28.4 (April 21).
Fixed
TP-181 / fix: wire worker model from preferences through to lane runner #522 (@NerfEko) —
taskRunner.worker.{model,thinking,tools}from preferences now actually flow through to spawned workers. PreviouslyLaneRunnerConfig.workerModelwas hardcoded to""and the user's worker model config was silently ignored. Mirrors the existing reviewer pipeline (TP-160). +11 tests.TP-183 / Improve UX when Taskplane is not configured in current workspace #523 (@mwickens) — Pi no longer hard-blocks startup with a verbose red
WORKSPACE_SETUP_REQUIREDerror when run in directories without Taskplane configured. Soft-fails to a quiet status indicator (🔀 Orchestrator · disabled (no taskplane config in workspace)). All otherWorkspaceConfigErrorCodevalues still surface loudly so real misconfigurations stay visible. +6 tests.TP-184 / Workers cannot call review_step / notify_supervisor / request_segment_expansion — missing from hardcoded tool allowlist #530 — Workers can now invoke
review_step,notify_supervisor,escalate_to_supervisor, andrequest_segment_expansion. Engine-internal coordination tools were missing from the worker--toolsallowlist, so plan/code/test reviews silently never fired at Review Level ≥ 1, supervisor steering replies were impossible, and multi-repo segment expansion was unreachable. NewENGINE_BRIDGE_TOOLSconstant +buildWorkerToolsAllowlist()helper. +14 tests.TP-185 — Preflight
picheck no longer misreports cold-start timeouts as "Pi not found".execCheckclassifies failures by mode (not-found,timeout,exit-code,signal,unknown). Pi preflight uses 30s timeout (up from 10s) and retries once. Tailored failure hints. Backward compatible. +9 tests.Validation
taskplane helpandtaskplane doctorcleannpm pack --dry-run)review_stepcalls, 2 verdict files, Review Counter = 2)escalate_to_supervisorwas missing) and TP-183 (no blockers; 1 optional improvement applied)Test count growth
What's NOT in this release (deferred)
lane-runner.tsspawn-site wiring, migration of duplicated literals to a shared lightweight constants module, behavioral helper extraction for TP-183 testability, fix fortaskplane doctoremptypi installed ()display (pi prints version to stderr; getVersion only reads stdout)Tag
v0.28.5already pushed to origin and points at the0.28.5commit on this branch. Use--merge(not squash) when merging this PR so the tagged commit stays in main's linear history forgit describeandgh release create v0.28.5.Post-merge sequence
--merge(preserves the tagged commit)npm publishgh release create v0.28.5 --title "v0.28.5" --notes-from-tag(or with a custom body matching this PR)npm view taskplane versionandgh release view v0.28.5